fix(compiler): support properties on SVG elements#5653
fix(compiler): support properties on SVG elements#5653teropa wants to merge 1 commit intoangular:masterfrom
Conversation
|
This introduces some duplicated code between |
|
@teropa thanks for the fix. I think we have to live with the code duplication for now as the compiler code might not be loaded if the templates are pre-compiled. However could you try to somehow factorize https://github.com/angular/angular/blob/master/modules/angular2/src/compiler/html_parser.ts#L249 and your code (may be in html_tags ?). Please allow changes |
1a9e5ff to
cf6c0d3
Compare
|
@vicb Pushed an attempt to combine the two via |
|
The new test is failing in all IEs, Androids (4.1 to 4.3) and Safari 7/iOS7: |
9c69656 to
d5086fd
Compare
|
Thanks @Mlaval, should be OK now |
|
LGTM with a small cleanup, thanks ! |
Have DomElementSchemaRegistry support namespaced elements, so that it does not fail when directives are applied in SVG (or xlink). Without this fix, directives or property bindings cannot be used in SVG. Related to angular#5547
d5086fd to
ebddac6
Compare
|
@teropa could you please rebase ? |
There was a problem hiding this comment.
what about adding a test that would be falsy ?
|
Merging PR #5653 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5653. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Have
DomElementSchemaRegistrysupport namespaced elements,so that it does not fail when directives are applied in SVG (or xlink).
Without this fix, directives or property bindings cannot be
used in SVG.
Partially closes #5547