feat(core): provide support for relative assets for components by matsko · Pull Request #5634 · angular/angular

matsko · 2015-12-05T10:22:57Z

Assets defined for templateUrl and styleUrls can now be loaded
in relative to where the component file is placed so long as the
moduleId is set within the component annotation.

0x-r4bbit · 2015-12-05T15:17:43Z

modules/playground/src/relative_assets/my_cmp/my_cmp.ts

@matsko you should start a career as rapper.

IgorMinar · 2015-12-05T16:12:35Z

Several dart analyzer failures

vicb · 2015-12-05T16:22:08Z

modules/angular2/src/core/application_tokens.ts

Why package if it's the application root ?

Application root is too broad. It is the root where modules are loaded from.
So maybe MODULE_ROOT_URL.

Updated to MODULE_ROOT_URL.

vicb · 2015-12-05T16:49:59Z

Some comments in the PR.

I am also -1 on the moduleId name in the Directive annotation. This name is CJS specific and has nothing to do with angular. What about baseUrl or something like that, independent of a given implementation ?
Also why do we need moduleId on @Directive (vs @Component)

This is not directly related to this PR

tbosch · 2015-12-07T15:58:53Z

+1 for only having the moduleId on @Component
+1 for changing moduleId to something else.

tbosch · 2015-12-07T16:00:07Z

modules/angular2/src/compiler/url_resolver.dart

Why can't this stay final?

From what I was struggling with using Dart, it can't stay final because the value is determined within the body of the constructor. The error that shows up is so:

'UrlResolver' has no instance setter '_packagePrefix'.

Please talk to Yegor, this should be doable

IgorMinar · 2015-12-09T00:29:12Z

e2e tests are failing. looks like a legit issue.

Assets defined for `templateUrl` and `styleUrls` can now be loaded in relative to where the component file is placed so long as the `moduleId` is set within the component annotation. Closes angular#5634

mary-poppins · 2015-12-09T22:02:32Z

Merging PR #5634 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5634.

Assets defined for `templateUrl` and `styleUrls` can now be loaded in relative to where the component file is placed so long as the `moduleId` is set within the component annotation. Closes angular#5634

rolandjitsu · 2015-12-10T16:09:43Z

So happy this landed 👍 Just one question, is moduleId: module.id necessary or has/will it been renamed to something else?

IgorMinar · 2015-12-10T17:36:11Z

It's necessary for CJS modules.

Matias, can you send the PR with doc updates describing how to use this. I
believe that you wanted to do it in a separate PR.
On Thu, Dec 10, 2015 at 8:09 AM Roland Groza notifications@github.com
wrote:

So happy this landed [image: 👍] Just one question, is moduleId:
module.id necessary or has/will it been renamed to something else?

—
Reply to this email directly or view it on GitHub
#5634 (comment).

michaeloryl · 2016-01-01T16:21:27Z

Does this actually work? I'm trying to get it to work in beta.0 and see no impact from having moduleId: module.id in the Component decorator. And the docs still don't reflect it either, best I can find.

angular-automatic-lock-bot · 2019-09-10T06:21:06Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Dec 5, 2015

matsko force-pushed the resolve_url_new branch from 7691d55 to 806d717 Compare December 5, 2015 10:24

matsko force-pushed the resolve_url_new branch from 806d717 to 009295e Compare December 5, 2015 10:28

matsko force-pushed the resolve_url_new branch from 009295e to 416315c Compare December 5, 2015 10:29

matsko force-pushed the resolve_url_new branch from 416315c to 3598c08 Compare December 5, 2015 10:34

0x-r4bbit reviewed Dec 5, 2015
View reviewed changes

modules/playground/src/relative_assets/my_cmp/my_cmp.ts Outdated

Copy link
Copy Markdown

Contributor

0x-r4bbit Dec 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matsko you should start a career as rapper.

IgorMinar assigned tbosch Dec 5, 2015

IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 5, 2015

IgorMinar added this to the beta.0 milestone Dec 5, 2015

vicb reviewed Dec 5, 2015
View reviewed changes

tbosch reviewed Dec 7, 2015
View reviewed changes

tbosch added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 8, 2015

matsko force-pushed the resolve_url_new branch from 70a8f03 to 59ced85 Compare December 8, 2015 20:03

matsko force-pushed the resolve_url_new branch from 59ced85 to d78367e Compare December 8, 2015 20:05

matsko force-pushed the resolve_url_new branch from d78367e to 124b83c Compare December 8, 2015 23:13

matsko force-pushed the resolve_url_new branch from 124b83c to 961f26b Compare December 9, 2015 06:35

matsko force-pushed the resolve_url_new branch from 961f26b to 9d1da8d Compare December 9, 2015 07:05

matsko force-pushed the resolve_url_new branch from 9d1da8d to 50fa0e2 Compare December 9, 2015 20:01

matsko force-pushed the resolve_url_new branch from 50fa0e2 to c0ab8b3 Compare December 9, 2015 20:51

feat(core): provide support for relative assets for components

5399276

Assets defined for `templateUrl` and `styleUrls` can now be loaded in relative to where the component file is placed so long as the `moduleId` is set within the component annotation. Closes angular#5634

matsko force-pushed the resolve_url_new branch from c0ab8b3 to 5399276 Compare December 9, 2015 21:16

alexeagle added the zomg_admin: do merge label Dec 9, 2015

mary-poppins removed the zomg_admin: do merge label Dec 9, 2015

matsko closed this in db096a5 Dec 9, 2015

matsko deleted the resolve_url_new branch November 14, 2016 21:05

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Conversation

matsko commented Dec 5, 2015

Uh oh!

0x-r4bbit Dec 5, 2015

Choose a reason for hiding this comment

Uh oh!

IgorMinar commented Dec 5, 2015

Uh oh!

vicb Dec 5, 2015

Choose a reason for hiding this comment

Uh oh!

tbosch Dec 7, 2015

Choose a reason for hiding this comment

Uh oh!

matsko Dec 7, 2015

Choose a reason for hiding this comment

Uh oh!

vicb commented Dec 5, 2015

Uh oh!

tbosch commented Dec 7, 2015

Uh oh!

tbosch Dec 7, 2015

Choose a reason for hiding this comment

Uh oh!

matsko Dec 7, 2015

Choose a reason for hiding this comment

Uh oh!

tbosch Dec 7, 2015

Choose a reason for hiding this comment

Uh oh!

IgorMinar commented Dec 9, 2015

Uh oh!

mary-poppins commented Dec 9, 2015

Uh oh!

rolandjitsu commented Dec 10, 2015

Uh oh!

IgorMinar commented Dec 10, 2015

Uh oh!

michaeloryl commented Jan 1, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants