fix(dart/reflection): Fix NoReflectionCapabilities interface#5578
Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
Closed
fix(dart/reflection): Fix NoReflectionCapabilities interface#5578kegluneq wants to merge 1 commit intoangular:masterfrom
NoReflectionCapabilities interface#5578kegluneq wants to merge 1 commit intoangular:masterfrom
Conversation
yjbanov
added
pr_state: LGTM
action: merge
Contributor
|
@kegluneq is the failure on Travis legitimate? |
Author
|
Yes and no 😃 |
Make `NoReflectionCapabilities` conform to the `PlatformReflectionCapbilities` api, which prevents some confusing error messages. Closes angular#5559
kegluneq
force-pushed
the
dart_fix_reflection
branch
from
7c23188 to
238357a
Compare
Contributor
|
Looks good regarding public api change |
Author
|
Merging PR #5578 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5578. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
NoReflectionCapabilitiesconform to thePlatformReflectionCapbilitiesapi, which prevents some confusing error messages.
Closes #5559