Pattern validator#5561
Closed
awiseman wants to merge 1 commit intoangular:masterfrom
awiseman:pattern-validator
Closed
Pattern validator#5561awiseman wants to merge 1 commit intoangular:masterfrom awiseman:pattern-validator
awiseman wants to merge 1 commit intoangular:masterfrom
awiseman:pattern-validator
Conversation
Contributor
|
@vsavkin can you chime in on what's going on here? |
jelbourn
added
the
action: cleanup
Contributor
|
@awiseman you can update the public api spec |
Adding static pattern validation method to Validators Adding a directive for the pattern validator Applying clang-format rules to modified files Updating public api spec for new pattern validator Adding pattern validator to public api guard tool For #5411
Contributor
Author
|
ok, should be all set. |
vsavkin
added
pr_state: LGTM
action: merge
|
Merging PR #5561 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5561. |
akirasosa
added a commit
to springboot-angular2-tutorial/angular2-app
that referenced
this pull request
Mar 4, 2016
ruchirsachdeva
added a commit
to ruchirsachdeva/angular-web-client
that referenced
this pull request
Feb 19, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5411
Currently one unit test is failing: public_api_spec.ts
The comment said to not modify without permission, so I left it alone.