feat(testability): Expose function frameworkStabilizers by hankduan · Pull Request #5485 · angular/angular

hankduan · 2015-11-25T23:10:35Z

No description provided.

hankduan · 2015-11-25T23:57:18Z

Julie, can you take a look?

juliemr · 2015-12-01T20:59:02Z

modules/angular2/src/core/testability/testability.ts

A comment on what this is for might be useful for someone unfamiliar with the goal of our framework stabilizers.

juliemr · 2015-12-01T21:05:06Z

Sorry for the slow review! Looks like the dart tests are failing. Other than that looks ok.

juliemr · 2015-12-01T21:07:14Z

Also, modify tests at https://github.com/angular/angular/blob/master/modules/angular2/test/core/testability/testability_spec.ts to look for didWork please!

hankduan · 2015-12-02T20:25:29Z

Added comment for didWork and added tests. Still trying to figure out what's wrong with the dart tests ...

hankduan · 2015-12-04T22:13:49Z

Still can't figure out what is wrong and angular does not build on my local machine properly, so it's making life difficult.
I'll come back to this in week of 12/14

hankduan · 2015-12-17T02:10:06Z

Ok...slight (although not very useful) update. The same code passes when I run the e2e tests locally =/

juliemr · 2015-12-18T18:35:19Z

This looks good to me! Assigning to @tbosch for a quick sanity check. cc @goderbauer

tbosch · 2015-12-21T18:26:12Z

modules/angular2/src/platform/browser/testability.ts

@juliemr Can we write a test that uses global.frameworkStabilizers?

tbosch · 2015-12-21T18:27:00Z

Looks good as well. Would be nice to have a test for the new feature though... (i.e. access global.frameworkStabilizers from an e2e test...

hankduan · 2015-12-21T23:00:54Z

Added e2e test

tbosch · 2015-12-30T00:43:04Z

Looks good!

mary-poppins · 2016-01-05T20:46:00Z

User @hankduan does not have PR merging privileges.

hankduan · 2016-01-05T20:58:41Z

squashed both commits together

mary-poppins · 2016-01-11T18:52:40Z

Merging PR #5485 on behalf of @rkirov to branch presubmit-rkirov-pr-5485.

angular-automatic-lock-bot · 2019-09-07T20:21:11Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Nov 25, 2015

hankduan force-pushed the frameworkStabilizers branch 5 times, most recently from 94ed92f to 16c6428 Compare November 25, 2015 23:44

hankduan assigned juliemr Nov 25, 2015

hankduan added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 25, 2015

hankduan force-pushed the frameworkStabilizers branch from 16c6428 to 606fc4b Compare November 30, 2015 06:30

juliemr reviewed Dec 1, 2015
View reviewed changes

juliemr assigned hankduan and unassigned juliemr Dec 1, 2015

hankduan force-pushed the frameworkStabilizers branch from 606fc4b to a869393 Compare December 2, 2015 20:24

hankduan force-pushed the frameworkStabilizers branch 10 times, most recently from 19c4f05 to 3530d8c Compare December 3, 2015 22:24

hankduan force-pushed the frameworkStabilizers branch from 3530d8c to 9aa8956 Compare December 17, 2015 00:54

juliemr added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 18, 2015

juliemr assigned tbosch and unassigned hankduan Dec 18, 2015

tbosch reviewed Dec 21, 2015
View reviewed changes

tbosch added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 21, 2015

tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 21, 2015

hankduan force-pushed the frameworkStabilizers branch 3 times, most recently from 0c68225 to 666913a Compare December 21, 2015 22:31

tbosch removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 30, 2015

hankduan added action: merge The PR is ready for merge by the caretaker zomg_admin: do merge labels Dec 30, 2015

mary-poppins removed the zomg_admin: do merge label Jan 5, 2016

feat(testability): Expose function frameworkStabilizers

8152833

hankduan force-pushed the frameworkStabilizers branch from 666913a to 8152833 Compare January 5, 2016 20:57

rkirov added the zomg_admin: do merge label Jan 11, 2016

mary-poppins removed the zomg_admin: do merge label Jan 11, 2016

mhevery closed this in 69ae363 Jan 11, 2016

rolandjitsu mentioned this pull request Feb 13, 2016

fix: unit tests are not working rolandjitsu/angular-lab#48

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019

Conversation

hankduan commented Nov 25, 2015

Uh oh!

hankduan commented Nov 25, 2015

Uh oh!

juliemr Dec 1, 2015

Choose a reason for hiding this comment

Uh oh!

juliemr commented Dec 1, 2015

Uh oh!

juliemr commented Dec 1, 2015

Uh oh!

hankduan commented Dec 2, 2015

Uh oh!

hankduan commented Dec 4, 2015

Uh oh!

hankduan commented Dec 17, 2015

Uh oh!

juliemr commented Dec 18, 2015

Uh oh!

tbosch Dec 21, 2015

Choose a reason for hiding this comment

Uh oh!

tbosch commented Dec 21, 2015

Uh oh!

hankduan commented Dec 21, 2015

Uh oh!

tbosch commented Dec 30, 2015

Uh oh!

mary-poppins commented Jan 5, 2016

Uh oh!

hankduan commented Jan 5, 2016

Uh oh!

mary-poppins commented Jan 11, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants