X Tutup
Skip to content

fix(build): fix source maps#5444

Closed
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:fix_sourcemaps
Closed

fix(build): fix source maps#5444
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:fix_sourcemaps

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Nov 23, 2015

No description provided.

@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 23, 2015
@jeffbcross
Copy link
Copy Markdown
Contributor

screen shot 2015-11-23 at 1 11 14 pm

The reporter doesn't do a very good job of showing when a test has failed. This screenshot is of a test that timed out, but the experience isn't much better when the test throws. All I see is:

[13:13:22] Starting '!test.unit.js/karma-run'...
Chrome 46.0.2490 (Mac OS X 10.10.5) integration tests react to record changes should consume text node changes FAILED
error message thrown
23 11 2015 13:13:41.237:WARN [Chrome 46.0.2490 (Mac OS X 10.10.5)]: Disconnected (1 times), because no message in 10000 ms.
Chrome 46.0.2490 (Mac OS X 10.10.5): Executed 1 of 2299 (1 FAILED) (skipped 91) DISCONNECTED (10.052 secs / 0.044 secs)
[13:13:41] Finished '!test.unit.js/karma-run' after 19 s

@jeffbcross
Copy link
Copy Markdown
Contributor

LGTM with local fixes to color reporter and indentation.

@jeffbcross jeffbcross assigned vsavkin and unassigned jeffbcross Nov 23, 2015
@jeffbcross jeffbcross added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 23, 2015
@vsavkin vsavkin added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 23, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5444 on behalf of @alxhub to branch presubmit-alxhub-pr-5444.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

X Tutup