X Tutup
Skip to content

feat(parser): allow users install custom AST transforms#5382

Closed
yjbanov wants to merge 1 commit intoangular:masterfrom
yjbanov:template-transforms
Closed

feat(parser): allow users install custom AST transforms#5382
yjbanov wants to merge 1 commit intoangular:masterfrom
yjbanov:template-transforms

Conversation

@yjbanov
Copy link
Copy Markdown
Contributor

@yjbanov yjbanov commented Nov 19, 2015

No description provided.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsavkin is this not the same as the following?

@Optional @Inject(TEMPLATE_TRANSFORMS) public transforms

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is the same.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yjbanov
Copy link
Copy Markdown
Contributor Author

yjbanov commented Nov 19, 2015

/cc @btford @alxhub

@yjbanov yjbanov changed the title feat(parser): allows users install custom AST transformers feat(parser): allow users install custom AST transformers Nov 19, 2015
@yjbanov yjbanov changed the title feat(parser): allow users install custom AST transformers feat(parser): allow users install custom AST transforms Nov 19, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import form angular2/core.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vsavkin vsavkin assigned yjbanov and unassigned vsavkin Nov 19, 2015
@yjbanov yjbanov force-pushed the template-transforms branch 3 times, most recently from 11f95d4 to a1345e3 Compare November 19, 2015 22:08
@yjbanov yjbanov force-pushed the template-transforms branch from a1345e3 to 6abaf32 Compare November 20, 2015 00:24
@yjbanov yjbanov added the action: merge The PR is ready for merge by the caretaker label Nov 20, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5382 on behalf of @alxhub to branch presubmit-alxhub-pr-5382.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOC, is Injector needed here ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch: #5424

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

X Tutup