fix(dart/transform): Consider of line numbers in inliner_for_test#5285
Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
Closed
fix(dart/transform): Consider of line numbers in inliner_for_test#5285kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq wants to merge 1 commit intoangular:masterfrom
Conversation
kegluneq
added
type: bug/fix
comp: dart-transformer
action: review
There was a problem hiding this comment.
add "Style" to the key for readability: _vStyle0
|
Thanks for the quick fix. The team and our stack traces appreciate it ! |
kegluneq
force-pushed
the
fix_i5281
branch
2 times, most recently
from
fd84d98 to
e30c845
Compare
Ensure that line numbers aren't changed by inliner_for_test. Fixes angular#5281
Author
|
Updated the inline value names to PTAL |
tbosch
added
pr_state: LGTM
and removed
action: review
Author
|
Ready for commit - thanks! |
|
Merging PR #5285 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5285. |
|
Merging PR #5285 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5285. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that line numbers aren't changed by inliner_for_test.
Fixes #5281