fix(transformers): Fix @Input/@Output annotations with setters/getters#5259
Closed
TedSander wants to merge 1 commit intoangular:masterfrom
Closed
fix(transformers): Fix @Input/@Output annotations with setters/getters#5259TedSander wants to merge 1 commit intoangular:masterfrom
TedSander wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
Author
TedSander
added
the
action: review
Fix @input annotations to work with setter methods in dart, and fix @output annotations to work with getter methods in Dart when using transformers. Closes angular#5251
TedSander
force-pushed
the
AnnotationTransformerFix
branch
from
51af417 to
1a44b71
Compare
vsavkin
added
pr_state: LGTM
action: merge
|
Merging PR #5259 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5259. |
mary-poppins
removed
the
action: merge
TedSander
removed
the
action: review
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix @input annotations to work with setter methods in dart, and fix @output
annotations to work with getter methods in Dart when using transformers.