X Tutup
Skip to content

fix(build): reorder bundling step#5208

Closed
robwormald wants to merge 1 commit intoangular:masterfrom
robwormald:fix/build-order
Closed

fix(build): reorder bundling step#5208
robwormald wants to merge 1 commit intoangular:masterfrom
robwormald:fix/build-order

Conversation

@robwormald
Copy link
Copy Markdown
Contributor

@robwormald robwormald commented Nov 10, 2015

Previously, each bundle gulp task would kick off 3 bundle processes in parallel, and the tasks themselves are kicked off in parallel. This leads to 9+ bundle / source-mapping / minification tasks running in parallel, and causes CI to be quite flaky, exhibiting errors like:

Security context: 0x21ef97b37399 <JS Object>
    2: _serializeMappings(aka SourceMapGenerator_serializeMappings) [/home/travis/build/angular/angular/node_modules/systemjs-builder/node_modules/source-map/lib/source-map/source-map-generator.js:~289] [pc=0x244e65cef4ed] (this=0x2c83a9f9e379 <a SourceMapGenerator with map 0x2b2aab242ed1>)
    3: toJSON(aka SourceMapGenerator_toJSON) [/home/travis/build/angular/angular/node_modules/systemjs-bu...
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memory

This reorders each task slightly so the main bundle step completes before the aux modules get bundled.

@naomiblack naomiblack added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 10, 2015
@jeffbcross jeffbcross added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Nov 10, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Nov 10, 2015

Merging PR #5208 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-5208.

1 similar comment
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Nov 10, 2015

Merging PR #5208 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-5208.

@mary-poppins mary-poppins removed action: merge The PR is ready for merge by the caretaker labels Nov 10, 2015
@robwormald robwormald mentioned this pull request Nov 11, 2015
Closed
2 tasks
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robwormald @mary-poppins @jeffbcross @naomiblack @googlebot
X Tutup