X Tutup
Skip to content

Transformers support input outputs#5080

Closed
vsavkin wants to merge 5 commits intoangular:masterfrom
vsavkin:transformers_support_input_outputs
Closed

Transformers support input outputs#5080
vsavkin wants to merge 5 commits intoangular:masterfrom
vsavkin:transformers_support_input_outputs

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Nov 2, 2015

No description provided.

@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 2, 2015
gkalpak
gkalpak reviewed Nov 2, 2015
View reviewed changes
modules/playground/src/order_management/index.ts
Copy link
Copy Markdown
Member

@gkalpak gkalpak Nov 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at it, feel free to add a timy little leading space :)

@vsavkin vsavkin added this to the beta-00 milestone Nov 2, 2015
kegluneq
kegluneq reviewed Nov 3, 2015
View reviewed changes
modules_dart/transform/lib/src/transform/common/directive_metadata_reader.dart Outdated
Copy link
Copy Markdown

@kegluneq kegluneq Nov 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this logic to a reusable method (or top-level function)

Copy link
Copy Markdown
Contributor Author

@vsavkin vsavkin Nov 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@kegluneq kegluneq added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 3, 2015
@kegluneq kegluneq assigned vsavkin and unassigned kegluneq Nov 3, 2015
@vsavkin vsavkin force-pushed the transformers_support_input_outputs branch from f7a9f38 to 2e8d2a9 Compare November 3, 2015 00:43
@vsavkin vsavkin force-pushed the transformers_support_input_outputs branch from 2e8d2a9 to d7b6472 Compare November 3, 2015 00:45
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Nov 3, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Nov 3, 2015

Merging PR #5080 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5080.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Nov 3, 2015
@vsavkin vsavkin closed this in 16bc238 Nov 3, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Milestone

beta.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vsavkin @mary-poppins @kegluneq @gkalpak @googlebot
X Tutup