X Tutup
Skip to content

Form Async Validations Final Cleanup#5032

Closed
vsavkin wants to merge 3 commits intoangular:masterfrom
vsavkin:forms_async_validations_3
Closed

Form Async Validations Final Cleanup#5032
vsavkin wants to merge 3 commits intoangular:masterfrom
vsavkin:forms_async_validations_3

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Oct 30, 2015

Please review only the last three commits.

Introduced changes:

  • Validators can return observables instead of promises
  • Every form control in addition to valueChanges provides statusChanges

@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 30, 2015
@vsavkin vsavkin force-pushed the forms_async_validations_3 branch from e0128b4 to b78213a Compare November 2, 2015 19:58
@naomiblack naomiblack modified the milestone: beta-00 Nov 2, 2015
@vsavkin vsavkin force-pushed the forms_async_validations_3 branch from b78213a to 6e8a788 Compare November 6, 2015 01:09
@vsavkin vsavkin force-pushed the forms_async_validations_3 branch from 6e8a788 to d92cad5 Compare November 6, 2015 01:18
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5032 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5032.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Nov 6, 2015
@vsavkin vsavkin closed this in 4439106 Nov 6, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup