fix(lang): avoid infinite loop when calling assert()#4983
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Closed
fix(lang): avoid infinite loop when calling assert()#4983pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
add a TODO with a reference to the issue number ?
Member
Author
There was a problem hiding this comment.
It is below, in the assert function
Contributor
|
One small comment, otherwise LGTM |
mhevery
added
the
action: cleanup
The current code doesn't function properly: - assert are never activated - even if activated would result in infinite loop Since the code is broken and blocks other use-cases this commit turns assert into noop. A proper solution for asserts will be part of angular#2830 Fixes angular#4981
pkozlowski-opensource
force-pushed
the
assert_noop
branch
from
befc565 to
78c885e
Compare
pkozlowski-opensource
added
action: merge
|
Merging PR #4983 on behalf of @pkozlowski-opensource to branch presubmit-pkozlowski-opensource-pr-4983. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code doesn't function properly:
Since the code is broken and blocks other use-cases
this commit turns assert into noop. A proper solution
for asserts will be part of #2830
Fixes #4981