X Tutup
Skip to content

Ng control group validators#4954

Closed
vsavkin wants to merge 2 commits intoangular:masterfrom
vsavkin:ng_control_group_validators
Closed

Ng control group validators#4954
vsavkin wants to merge 2 commits intoangular:masterfrom
vsavkin:ng_control_group_validators

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Oct 27, 2015

Currently, it is not possible to add validators to control groups in the template. This limits template driven forms. This PR makes it possible.

<form some-form-validator>
  <div same-passwords>
    <input ng-control="password">
    <input ng-control="passwordConfirm">
  </div>
</form>

@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 27, 2015
@mhevery mhevery added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 27, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 27, 2015

Merging PR #4954 on behalf of @mhevery to branch presubmit-mhevery-pr-4954.

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Oct 27, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 27, 2015
@mhevery mhevery assigned vsavkin and unassigned mhevery Oct 27, 2015
@vsavkin vsavkin closed this in 7580628 Oct 28, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vsavkin @mary-poppins @mhevery @googlebot
X Tutup