X Tutup
Skip to content

fix(default_value_accessor): support custom input elements that fire …#4878

Closed
tbosch wants to merge 1 commit intoangular:masterfrom
tbosch:form_fix
Closed

fix(default_value_accessor): support custom input elements that fire …#4878
tbosch wants to merge 1 commit intoangular:masterfrom
tbosch:form_fix

Conversation

@tbosch
Copy link
Copy Markdown
Contributor

@tbosch tbosch commented Oct 23, 2015

…custom change events.

@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Oct 23, 2015

@vsavkin FYI, had to roll back the change to the selector of DefaultValueAccessor as it breaks G3, added an integration test that explains why.

Essentially they have a custom input component that fires a change event which does not contain a target property. Therefore, the host listener of the DefaultValueAccessor failed.

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Oct 26, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #4878 on behalf of @tbosch to branch presubmit-tbosch-pr-4878.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 26, 2015
@tbosch tbosch closed this in 56a9b02 Oct 26, 2015
@tbosch tbosch deleted the form_fix branch October 26, 2015 20:56
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup