When deps is not provided, it is set to null. So the following two lines are equivalent:

const Binding(MyClass, toFactory: buildMyClass)
const Binding(MyClass, toFactory: buildMyClass, deps: null)

This is what the framework does: if (deps == null) { useReflectionToGetDeps() }

Basically, the current default means "use reflection". Using an empty list as a default makes sense only for functions without parameters. For example, assigning an empty list to the following factory is really strange:

const Binding(MyClass, toFactory: (@Inject("initNumber") x) => x + 100)

So we can use [] as a default only if we can get the function's arity, which requires using mirrors. But if you can use mirrors, you would not need to specify dependencies. That is why the default works the way it works.

We could change the API to make null similar to an empty list, but you would still have to explicitly pass null:

const Binding(MyClass, toFactory: buildMyClass, deps: null)
const Binding(MyClass, toFactory: buildMyClass, deps: const [])

But this one would still mean use reflection:

const Binding(MyClass, toFactory: buildMyClass)

But I think it might be even more confusing.

Bindings does not default deps to const[] #4866

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions