fix(compiler): attribute case when parsing HTML in IE9#4743
Closed
marclaval wants to merge 1 commit intoangular:masterfrom
Closed
fix(compiler): attribute case when parsing HTML in IE9#4743marclaval wants to merge 1 commit intoangular:masterfrom
marclaval wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
Author
|
@IgorMinar Sauce Labs is back to green :) |
Contributor
There was a problem hiding this comment.
attrName.toLowerCase() should work in both Dart & JS.(we should probably remove the methods (lower & upper) from the Wrapper).
Should you add a comment here ?
Contributor
|
Looks good |
ac6b40a to
a3d17f1
Compare
Contributor
|
lgtm |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating a test failure in IE9, I found an interesting issue about parsing attributes.
Consider the following code snippet:
Output in Chrome:
<div><input type="text" ng-control="min" maxlength="3" abc="4" efgh="5"></div>Output in Firefox:
<div><input type="text" ng-control="min" maxlength="3" ABC="4" efGH="5" /></div>Output in IE9:
<div><input maxLength="3" type="text" ng-control="min" efGH="5" ABC="4"></div>As you can see, IE9 and Firefox keep the case, and IE9 even modifies it in the particular case of
maxlength.Hence the proposal to lower case all attributes names to harmonize the behaviors.