fix(style_compiler): don’t touch urls in stylesheets and keep stylesh…#4740
Closed
tbosch wants to merge 1 commit intoangular:masterfrom
Closed
fix(style_compiler): don’t touch urls in stylesheets and keep stylesh…#4740tbosch wants to merge 1 commit intoangular:masterfrom
tbosch wants to merge 1 commit intoangular:masterfrom
Conversation
tbosch
force-pushed
the
url_resolve
branch
2 times, most recently
from
3e1160c to
c5c4824
Compare
…eets with absolute urls in templates We can’t resolve relative urls (e.g. for images) in the compiler as these urls are meant to be loaded in the browser (unless we would inline images as base64…). Also, keep `<link rel=“stylesheet”>` in templates that reference absolute urls with e.g. `http://`. This behavior was already present for `@import` rules within stylesheets.
|
Merging PR #4740 on behalf of @tbosch to branch presubmit-tbosch-pr-4740. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eets with absolute urls in templates
We can’t resolve relative urls (e.g. for images) in the compiler as
these urls are meant to be loaded in the browser
(unless we would inline images as base64…).
Also, keep
<link rel=“stylesheet”>in templates thatreference absolute urls with e.g.
http://. Thisbehavior was already present for
@importruleswithin stylesheets.