fix(compiler): explicitly support event bindings also on <template>…#4712
Closed
tbosch wants to merge 1 commit intoangular:masterfrom
Closed
fix(compiler): explicitly support event bindings also on <template>…#4712tbosch wants to merge 1 commit intoangular:masterfrom
<template>…#4712tbosch wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
let's file an issue to check for existence of a directive on the element
tbosch
added
the
action: cleanup
… elements Although these events don’t fire events themselves, there might be directives on them that fire events.
|
Merging PR #4712 on behalf of @tbosch to branch presubmit-tbosch-pr-4712. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… elements
Although these events don’t fire events themselves, there might be directives on them that fire events.