I'm -1 on useExisting, too vague.

A new comer can easily think that he could use an existing class, value or factory.

class Ford extends Car {

}

provide(Car, {useExisting: Ford}); // easy error

I would use useToken.

👍 for using useToken

Merging PR #4684 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4684.

just to follow up on useExisting vs useToken, we feel that both are a bit ambiguous in different ways. let's stick to useExisting for now and if we hear see a lot of confusion about this we can consider renaming. This feature should be rarely used, so as long as the docs clearly explain what it should be used for, I don't think we should waste too much time on the best naming. There are more frequently used apis that could use our attention instead.

SG to me

On Tue, Oct 13, 2015, 5:30 AM Igor Minar notifications@github.com wrote:

just to follow up on useExisting vs useToken, we feel that both are a bit
ambiguous in different ways. let's stick to useExisting for now and if we
hear see a lot of confusion about this we can consider renaming. This
feature should be rarely used, so as long as the docs clearly explain what
it should be used for, I don't think we should waste too much time on the
best naming. There are more frequently used apis that could use our
attention instead.

—
Reply to this email directly or view it on GitHub
#4684 (comment).

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}