feat(core): desugar [()] to [prop] and (prop-change)#4658
feat(core): desugar [()] to [prop] and (prop-change)#4658vsavkin wants to merge 1 commit intoangular:masterfrom
Conversation
672c4cd to
6d6b337
Compare
|
For
I think... |
|
Could you add backticks around code samples in the commit message so it shows correctly in the changelog? |
|
Also I think you need to rebase. |
BREAKING CHANGE Before ``` <cmp [(prop)]="field"> was desugared to <cmp [prop]="field" (prop)="field=$event"> ``` After ``` <cmp [(prop)]="field"> is desugared to <cmp [prop]="field" (prop-change)="field=$event"> ```
6d6b337 to
d093f11
Compare
|
Merging PR #4658 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4658. |
|
Could you provide any rationale why this was changed? Should all events be named with |
|
No, not all events have to have I think the reason for this change was just for semantic reasons. Before On Tue, Nov 24, 2015, 7:49 PM Roman notifications@github.com wrote:
|
|
Well, we still have events named like properties, just we need to change them depending if we want to use 2-way binding sugar. Thanks for comments! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
BREAKING CHANGE
Before
<cmp [(prop)]="field"> was desugared to <cmp [prop]="field" (prop)="field=$event">After
<cmp [(prop)]="field"> was desugared to <cmp [prop]="field" (prop-change)="field=$event">