X Tutup
Skip to content

fix(typings): add more missing typings.#4636

Closed
alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle:missing_function_param_types
Closed

fix(typings): add more missing typings.#4636
alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle:missing_function_param_types

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

This is the same bug pattern I reported in microsoft/TypeScript#5187

@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 9, 2015
@vicb
Copy link
Copy Markdown
Contributor

vicb commented Oct 9, 2015

👍
LGTM when Dart is green

@alexeagle alexeagle force-pushed the missing_function_param_types branch from 98526cb to 8c980ff Compare October 9, 2015 18:19
This is the same bug pattern I reported in microsoft/TypeScript#5187
@alexeagle alexeagle force-pushed the missing_function_param_types branch from 8c980ff to d6adfc6 Compare October 9, 2015 18:31
@mary-poppins
Copy link
Copy Markdown

Merging PR #4636 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4636.

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 9, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 9, 2015
@alexeagle alexeagle closed this in aab0c57 Oct 9, 2015
@alexeagle alexeagle deleted the missing_function_param_types branch October 9, 2015 19:37
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup