Closed
Conversation
alexeagle
added
the
action: review
Contributor
Author
|
Note, I filed microsoft/TypeScript#5187 with thoughts about preventing this kind of issue in the future. |
Contributor
There was a problem hiding this comment.
nit: what about applying the cast on l 222 ?
vicb
added
pr_state: LGTM
and removed
action: review
alexeagle
force-pushed
the
forEachWithIndex
branch
from
523d82a to
072db41
Compare
|
Merging PR #4625 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4625. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem will be caught by my new typings distribution, so fixing these is a prerequisite to enabling it.