fix(core): make .toRx() return Subject#4540
Closed
robwormald wants to merge 1 commit intoangular:masterfrom
Closed
fix(core): make .toRx() return Subject#4540robwormald wants to merge 1 commit intoangular:masterfrom
robwormald wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
|
👍 |
robwormald
force-pushed
the
fix/eventemitter
branch
from
0b57dde to
2cc32a3
Compare
this was broken in the original great RxNext migration. fixes angular#4521
robwormald
force-pushed
the
fix/eventemitter
branch
from
2cc32a3 to
1baa6c4
Compare
Contributor
|
@jeffbcross @vsavkin can any one approve this. Sounds like a major bug fix. |
jeffbcross
added
pr_state: LGTM
action: merge
|
Merging PR #4540 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-4540. |
Contributor
|
Looks good to me for now. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was broken in the original great RxNext migration.