X Tutup
Skip to content

chore(typings): re-enable type-checking on the browser trees#4508

Closed
alexeagle wants to merge 2 commits intoangular:masterfrom
alexeagle:type_check_browser_tree
Closed

chore(typings): re-enable type-checking on the browser trees#4508
alexeagle wants to merge 2 commits intoangular:masterfrom
alexeagle:type_check_browser_tree

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle commented Oct 4, 2015

this was accidentally disabled in 5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See #4507
My solution here is to remove the upgrade module from this compilation unit. + @mhevery

@alexeagle alexeagle force-pushed the type_check_browser_tree branch 2 times, most recently from 3d51048 to 8ecd891 Compare October 4, 2015 15:31
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Oct 5, 2015

Does your change stop running the upgrade tests? If it is just deployment think it is fine, but if it disables tests, then we need to look for a quick solution

IgorMinar
IgorMinar reviewed Oct 5, 2015
View reviewed changes
modules/upgrade/tsd.json Outdated
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar Oct 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this now?

Copy link
Copy Markdown
Contributor Author

@alexeagle alexeagle Oct 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because angularjs/angular.d.ts has a relative reference path pointing here.
In fact, this has not correctly type-checked ever since Misko wrote the upgrade package. We just weren't running the typechecker on the browser tree. It wasn't type-checked by node_tree either because of include: ['angular2/**', 'benchpress/**', '**/e2e_test/**'],. So @mhevery has been getting a free ride!

@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Oct 5, 2015

Tests can't run if the typescript files are never transpiled. Let's figure out a quick fix tomorrow - maybe another *_tree.ts file.
Note this change is one blocking my new hotness (check out https://github.com/alexeagle/angular2-distro/blob/master/README.md 😄 )

@alexeagle alexeagle force-pushed the type_check_browser_tree branch 3 times, most recently from f21bd66 to b2fab70 Compare October 5, 2015 20:30
@IgorMinar IgorMinar added this to the alpha-39 milestone Oct 5, 2015
@alexeagle alexeagle force-pushed the type_check_browser_tree branch from b2fab70 to a83dab3 Compare October 5, 2015 22:33
@alexeagle
chore(typings): re-enable type-checking on the browser trees
897ed45
@alexeagle
fix(typings): repair broken typechecks
1a303da 
We had the typechecker disabled by accident, and many problems snuck in

Fixes angular#4507
@alexeagle alexeagle force-pushed the type_check_browser_tree branch from a83dab3 to 1a303da Compare October 5, 2015 23:41
@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Oct 5, 2015

Updated to fix the upgrade package - removed the dependency on the angular typings and jquery, instead we hand-wrote a subset of angular.d.ts just for the upgrade package.

PTAL

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Oct 6, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 6, 2015

Merging PR #4508 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4508.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 6, 2015
@alexeagle alexeagle closed this in 6093e28 Oct 6, 2015
@alexeagle alexeagle deleted the type_check_browser_tree branch October 6, 2015 14:02
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

alpha-39

Development

Successfully merging this pull request may close these issues.

6 participants

@alexeagle @mhevery @mary-poppins @IgorMinar @vsavkin @googlebot
X Tutup