feat(query): make QueryList notify on changes via an observable#4395
feat(query): make QueryList notify on changes via an observable#4395vsavkin wants to merge 1 commit intoangular:masterfrom
Conversation
vsavkin
added
the
action: review
There was a problem hiding this comment.
You could probably omit the parenthesis around _.
|
Update QueryList documentation. I think it used to say 'this will be Observable' |
There was a problem hiding this comment.
Why are you recreating the list on every reset? I think this can cause problems because some users will store the QueryList in the component.
|
Mostly good, just a few conceptual questions before I can LGTM it. |
There was a problem hiding this comment.
lets rename this to dehydrate, hydrate and match injector cleanup.
rkirov
added
pr_state: LGTM
and removed
action: review
BREAKING CHANGE:
Before: query.onChange(() => ...);
After: query.changes.subscribe((iterable) => {});
vsavkin
force-pushed
the
make_query_observable
branch
from
4405bcc to
3ff3fd3
Compare
|
Merging PR #4395 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4395. |
mary-poppins
removed
the
action: merge
|
With alpha.38, angular2.d.ts does not define |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6 participants
BREAKING CHANGE:
Before: query.onChange(() => ...);
After: query.changes.subscribe((iterable) => {});