fix(test): StyleCompiler tests failing in Android browsers#4351
Closed
marclaval wants to merge 1 commit intoangular:masterfrom
Closed
fix(test): StyleCompiler tests failing in Android browsers#4351marclaval wants to merge 1 commit intoangular:masterfrom
marclaval wants to merge 1 commit intoangular:masterfrom
Conversation
marclaval
force-pushed
the
fixStyleCompilerTests
branch
from
10ca71e to
7852d09
Compare
marclaval
added
the
action: review
pkozlowski-opensource
added
pr_state: LGTM
and removed
action: review
Member
|
And the SauceLabs is green for all browsers, including IE9! Yay! |
pkozlowski-opensource
added
the
action: merge
|
Merging PR #4351 on behalf of @pkozlowski-opensource to branch presubmit-pkozlowski-opensource-pr-4351. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit d646463 has been "reverted" during a recent refactor, let's fix the tests again and make SauceLabs job green.