Closed
Conversation
There was a problem hiding this comment.
consider:
new Map.fromIterable(queryFields, value: (_) => 'Object');
vsavkin
force-pushed
the
transformers_field_query
branch
from
fe67b7a to
e9fbfbe
Compare
vsavkin
added
the
action: review
There was a problem hiding this comment.
Rather than type-casting here, consider doing something like:
var queries = node.expression.accept(_evaluator);
if (queries is! Map) {
throw new FormatException(
'Expected a map value for "queries", but got ${node.expression}',
node.toSource());
}
queryFields.addAll(queries.keys);
Or you could just store the map and get rid of asMap()
kegluneq
added
action: cleanup
vsavkin
force-pushed
the
transformers_field_query
branch
from
e9fbfbe to
595264e
Compare
|
Merging PR #4344 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4344. |
mary-poppins
removed
the
action: merge
vsavkin
force-pushed
the
transformers_field_query
branch
from
595264e to
1a075d5
Compare
|
Merging PR #4344 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4344. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.