feat(http): accept string for method in RequestOptions class and interface#4331
Closed
mgechev wants to merge 1 commit intoangular:masterfrom
mgechev:http-string-methods
Closed
feat(http): accept string for method in RequestOptions class and interface#4331mgechev wants to merge 1 commit intoangular:masterfrom mgechev:http-string-methods
mgechev wants to merge 1 commit intoangular:masterfrom
mgechev:http-string-methods
Conversation
Contributor
There was a problem hiding this comment.
Please keep the newline at the end of the file
Contributor
|
@mgechev I left a few comments to clean up, but otherwise looks good! Could you also squash into a single commit? |
jeffbcross
added
action: cleanup
Member
Author
|
@jeffbcross done! Let me know if I've missed something. |
jeffbcross
added
action: merge
Contributor
|
Pushing to presubmit to be merged! |
jeffbcross
added
pr_state: LGTM
and removed
action: cleanup
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #2840