X Tutup
Skip to content

fix(bug): reflect Dart interfaces from superclass as well#4222

Closed
alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle:fix4221
Closed

fix(bug): reflect Dart interfaces from superclass as well#4222
alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle:fix4221

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle commented Sep 16, 2015

fixes #4221

@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 16, 2015
@mhevery mhevery removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 17, 2015
@mhevery mhevery assigned alexeagle and unassigned mhevery Sep 17, 2015
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Sep 17, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 17, 2015

Merging PR #4222 on behalf of @mhevery to branch presubmit-mhevery-pr-4222.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 17, 2015
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Sep 17, 2015

Looks like you have a broken test.

@mhevery mhevery added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 17, 2015
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Sep 21, 2015

@alexeagle can you have a look?

@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Sep 21, 2015

yes, sorry, getting back to this...

@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Sep 22, 2015

I have no idea what is going on, the failures were in the js build and now they are in the dart build, look totally unrelated to what I did, and the build has been very flaky. But I've re-run a bunch of times and don't get a passing status. I think I need some help to get this merged.

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Sep 22, 2015

@alexeagle ping me when you get to your desk and I can help you repro this locally.

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 22, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 22, 2015

Merging PR #4222 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4222.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 22, 2015
@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Sep 22, 2015

got a passing run from Travis PR just now. Looks like a whole lot of flakiness. Trying the presubmit again.

@alexeagle alexeagle closed this in 577ee37 Sep 22, 2015
robwormald pushed a commit to robwormald/angular that referenced this pull request Sep 25, 2015
@alexeagle @robwormald
fix(bug): reflect Dart interfaces from superclass as well
fc3f1d2 
fixes angular#4221

Closes angular#4222
This was referenced Feb 8, 2016
Closed
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alexeagle alexeagle

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing dart reflection of interfaces on superclass

4 participants

@alexeagle @mary-poppins @mhevery @googlebot
X Tutup