fix(debug): make debug tools take ComponentRef#4203
Closed
harryterkelsen wants to merge 1 commit intoangular:masterfrom
harryterkelsen:enable-debug
Closed
fix(debug): make debug tools take ComponentRef#4203harryterkelsen wants to merge 1 commit intoangular:masterfrom harryterkelsen:enable-debug
harryterkelsen wants to merge 1 commit intoangular:masterfrom
harryterkelsen:enable-debug
Conversation
The debug tools used to take ApplicationRefs, which are the old return type of bootstrap. Now bootstrap returns ComponentRef, so the debug tools should be updated.
alxhub
added
pr_state: LGTM
action: merge
|
User @alxhub does not have PR merging privileges. |
mary-poppins
removed
the
action: merge
|
Merging PR #4203 on behalf of @alxhub to branch presubmit-alxhub-pr-4203. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debug tools used to take ApplicationRefs, which are the old return
type of bootstrap. Now bootstrap returns ComponentRef, so the debug
tools should be updated.
Fixes #4202