X Tutup
Skip to content

feat(ng_for): Add Even and Odd variables to ng_for#4181

Closed
TedSander wants to merge 1 commit intoangular:masterfrom
TedSander:EvenOddChange
Closed

feat(ng_for): Add Even and Odd variables to ng_for#4181
TedSander wants to merge 1 commit intoangular:masterfrom
TedSander:EvenOddChange

Conversation

@TedSander
Copy link
Copy Markdown
Contributor

Add even and odd local variables to ng_for to allow developers to style table rows differently and other features.

@0x-r4bbit
Copy link
Copy Markdown
Contributor

Lvgtm

Could you fix your commit message to use "odd" instead of "off"?

@TedSander TedSander changed the title feat(ng_for): Add Even and Off variables to ng_for feat(ng_for): Add Even and Odd variables to ng_for Sep 14, 2015
@TedSander
Copy link
Copy Markdown
Contributor Author

Done

@0x-r4bbit
Copy link
Copy Markdown
Contributor

Hey @TedSander your commit message still says "off". I think you just updated the PR title.

Add even and odd local variables to ng_for to allow developers to style table rows differently and other features.
@TedSander
Copy link
Copy Markdown
Contributor Author

Sorry about that @PascalPrecht should be fixed now.

@mhevery mhevery added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Sep 15, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #4181 on behalf of @mhevery to branch presubmit-mhevery-pr-4181.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 15, 2015
@TedSander TedSander closed this in a15b679 Sep 15, 2015
@TedSander TedSander deleted the EvenOddChange branch September 15, 2015 18:58
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup