X Tutup
Skip to content

Refactor router navigate method#4074

Closed
btford wants to merge 2 commits intoangular:masterfrom
btford:refactor-router-navigate-method
Closed

Refactor router navigate method#4074
btford wants to merge 2 commits intoangular:masterfrom
btford:refactor-router-navigate-method

Conversation

@btford
Copy link
Copy Markdown
Contributor

@btford btford commented Sep 9, 2015

@IgorMinar – can you please take a look at this?

Closes #4040

Previously, `router.navigate` took a string representing the URL.
Now, it accepts an array that mirrors the link DSL.

Closes angular#4040

BREAKING CHANGE

The old method has been renamed to `router.navigateByUrl`.
Either change your navigation calls to use the DSL (preferred) or
call `router.navigateByUrl` instead.
@btford btford added comp: router effort1: hours refactoring Issue that involves refactoring or code-cleanup labels Sep 9, 2015
@btford btford added this to the alpha-38 milestone Sep 9, 2015
@IgorMinar
Copy link
Copy Markdown
Contributor

please improve docs. the rest looks good

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 9, 2015
@IgorMinar IgorMinar assigned btford and unassigned IgorMinar Sep 9, 2015
@btford
Copy link
Copy Markdown
Contributor Author

btford commented Sep 9, 2015

Will do. Thanks!

@btford btford removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 11, 2015
@btford btford closed this in d9036c6 Sep 12, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes effort1: hours refactoring Issue that involves refactoring or code-cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Router.navigate should have an overload that accepts the tuple

3 participants

X Tutup