X Tutup
Skip to content

fix(WebWorker): Add zone support to MessageBus#4053

Closed
jteplitz wants to merge 1 commit intoangular:masterfrom
jteplitz:message-bus-zone
Closed

fix(WebWorker): Add zone support to MessageBus#4053
jteplitz wants to merge 1 commit intoangular:masterfrom
jteplitz:message-bus-zone

Conversation

@jteplitz
Copy link
Copy Markdown
Contributor

@jteplitz jteplitz commented Sep 8, 2015

No description provided.

@jteplitz jteplitz added action: review The PR is still awaiting reviews from at least one requested reviewer comp: core/webworker labels Sep 8, 2015
yjbanov
yjbanov reviewed Sep 8, 2015
View reviewed changes
modules/angular2/src/web_workers/debug_tools/multi_client_server_message_bus.dart Outdated
Copy link
Copy Markdown
Contributor

@yjbanov yjbanov Sep 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is customary to use _ for required but unused parameters. However, in this case, why do you need the parameter?

Copy link
Copy Markdown
Contributor Author

@jteplitz jteplitz Sep 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to have a parameter so that I can pass the function directly to onResult.listen above. Without it it won't match the argument signature. I'll change it to an underscore.

yjbanov
yjbanov reviewed Sep 8, 2015
View reviewed changes
modules/angular2/src/web_workers/shared/message_bus.ts Outdated
Copy link
Copy Markdown
Contributor

@yjbanov yjbanov Sep 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear what "use this zone" means. How about "Any callbacks attached to channels created from this [MessageBus] will be executed within the given [zone]"?

yjbanov
yjbanov reviewed Sep 8, 2015
View reviewed changes
modules/angular2/src/web_workers/shared/generic_message_bus.dart Outdated
Copy link
Copy Markdown
Contributor

@yjbanov yjbanov Sep 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this field to be public?

Copy link
Copy Markdown
Contributor

@yjbanov yjbanov Sep 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it at least be read-only?

@jteplitz jteplitz force-pushed the message-bus-zone branch 2 times, most recently from ee89542 to 43ddd3b Compare September 8, 2015 20:30
yjbanov
yjbanov reviewed Sep 8, 2015
View reviewed changes
modules/angular2/src/web_workers/shared/message_bus.ts Outdated
Copy link
Copy Markdown
Contributor

@yjbanov yjbanov Sep 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use similar wording as one in MessageBus.attachToZone doc comment.

@yjbanov yjbanov added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 8, 2015
@jteplitz jteplitz removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 8, 2015
@jteplitz jteplitz closed this in f3da37c Sep 8, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jteplitz @yjbanov @googlebot
X Tutup