remove traceur from the build pipeline#3974
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@pkozlowski-opensource The typescript version we are using produces bad -m system output. When trying to upgrade to a newer one I run into slew of other errors. I am sure that we can get it to work (maybe with some help from TS and system.js guys). However, since removing traceur has been pending for quite long on our task list, I rather go ahead with this option, because it just works. Note that system.js is still used as a module loader for the commonjs output for the e2e and unit tests runs, which means that shouldn't affect consumers. |
tools/broccoli/trees/browser_tree.ts
Outdated
|
Fix the failing tests. |
|
@alexeagle the issue is the one you know about systemjs/systemjs#712 and from some local testing with typescript@next it looks like it is fixed at TS head. However, upgrading TS leads to other jankiness. Lets get this in, upgrade TS and then try to flip es5 output back to 'system' (if we are still convinced that is important). |
rkirov
force-pushed
the
ts_es5
branch
3 times, most recently
from
2bd178a to
f8fff51
Compare
|
PTAL |
There was a problem hiding this comment.
doesn't this test now test that we don't have source mapping at all?
There was a problem hiding this comment.
Nope, before we did ts -> es6 -> es5 in two shots, and didn't properly merge the sourcemaps for the two jumps. So in the test we had to decode twice (once per transpilation).
Now, we have a direct ts -> es5, so we just need to read in one source map and compare with the original. Notice we read the expected line from modules/examples/src/sourcemap/index.ts
IgorMinar
added
the
action: cleanup
|
Note that we already cherry-picked one upstream TS-system fix into the TS we use for Angular |
|
@alexeagle right, but I rather put effort into bringing newer versions that are released on npm (currently looks like 1.6.0-beta), and avoid too much cherry-picking. Also system vs commonjs module format output doesn't seem critical to me, since system.js loads them both fine. |
rkirov
added
action: merge
|
Merging PR #3974 on behalf of @rkirov to branch presubmit-rkirov-pr-3974. |
This removes traceur from the compilation step in broccoli. Broccoli now transpiles to es5 using the typescript compiler.
System output does not work at the current versions of TS and system.js. Will revisit after upgrading TS. Removes unused traceur tooling.
|
Merging PR #3974 on behalf of @rkirov to branch presubmit-rkirov-pr-3974. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6 participants
npm traceur package is still used for traceur-runtime dependency.