Closed
Conversation
vsavkin
added
action: review
Contributor
|
LGTM with rename to "pure" instead of "stateless". |
Contributor
|
Yes "pure" sounds more accurate. |
By default, pipes are pure. This means that an instance of a pipe will be reused and the pipe will be called only when its arguments change. BREAKING CHANGE Before: @pipe({name: 'date'}) class DatePipe {} defines an impure pipe. After: @pipe({name: 'date'}) class DatePipe {} defines a pure pipe. @pipe({name: 'date', pure: false}) class DatePipe {} defines an impure pipe.
vsavkin
force-pushed
the
pipes_pure_by_default
branch
from
08fff6f to
08c628d
Compare
|
Merging PR #3966 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3966. |
vsavkin
added
action: merge
|
Merging PR #3966 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3966. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3915