X Tutup
Skip to content

Test lib fixes#3952

Closed
IgorMinar wants to merge 8 commits intoangular:masterfrom
IgorMinar:test_lib-fixes
Closed

Test lib fixes#3952
IgorMinar wants to merge 8 commits intoangular:masterfrom
IgorMinar:test_lib-fixes

Conversation

@IgorMinar
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar commented Sep 2, 2015

No description provided.

@IgorMinar IgorMinar added comp: build/pipeline area: testing Issues related to Angular testing features, such as TestBed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 2, 2015
@IgorMinar IgorMinar added this to the alpha-37 milestone Sep 2, 2015
@jeffbcross
Copy link
Copy Markdown
Contributor

jeffbcross commented Sep 2, 2015

Looks good once the issues are fixed.

Here's the branch commit of the work we started, @IgorMinar jeffbcross@0765071

@jeffbcross jeffbcross assigned IgorMinar and unassigned jeffbcross Sep 2, 2015
@jeffbcross jeffbcross added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer comp: build/pipeline labels Sep 2, 2015
@jeffbcross
Copy link
Copy Markdown
Contributor

jeffbcross commented Sep 2, 2015

BTW I removed a comp: label because @mhevery's dashboard assumes only one component label.

@googlebot
Copy link
Copy Markdown

googlebot commented Sep 3, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no and removed cla: yes labels Sep 3, 2015
@IgorMinar IgorMinar force-pushed the test_lib-fixes branch 4 times, most recently from 146e838 to 95b336b Compare September 3, 2015 21:46
@googlebot
Copy link
Copy Markdown

googlebot commented Sep 3, 2015

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 3, 2015
@IgorMinar
style(di): fix a variable name typo
295390c
@IgorMinar
refactor(collection.ts): simplify ListWrapper.clear implementation
0c9eb4e
@IgorMinar
fix(fake_async): remove unused variable
280a0b8
@IgorMinar
fix(test_lib): reexport fake_async via angular/test
c5e3027 
previously fake_async was not being publically exported at all
@IgorMinar
fix(build): add config for outputting the missing test_lib.d.ts file
da16b9b
@IgorMinar
fix(test_lib): add missing types
d88b61f
@IgorMinar
fix(dts generation): rewrite the d.ts file code generator to fix bugs…
2404f7f 
… and apply type remap correctly

Previously the type remap was not being applied to comments and free floating functions.

The nunjucks template was becoming unreadable so rather than making a tweak there I
rewrote it into imperative code that is much easier to follow.

The output was diffed against the old output. The diff contained only the expected changes.
@IgorMinar
Copy link
Copy Markdown
Contributor Author

IgorMinar commented Sep 3, 2015

there seems to be a flaky test that intermittently fails on travis. AFAIK it is not being introduced by my changes, so I'll send this to the presubmit queue as is.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Sep 3, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 3, 2015

Merging PR #3952 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-3952.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 3, 2015
@IgorMinar IgorMinar closed this in d782616 Sep 4, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@IgorMinar IgorMinar

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: testing Issues related to Angular testing features, such as TestBed cla: yes

Projects

None yet

Milestone

alpha-37

Development

Successfully merging this pull request may close these issues.

4 participants

@IgorMinar @jeffbcross @googlebot @mary-poppins
X Tutup