feat(compiler): allow to create ChangeDetectors from parsed templates#3950
Closed
tbosch wants to merge 1 commit intoangular:masterfrom
Closed
feat(compiler): allow to create ChangeDetectors from parsed templates#3950tbosch wants to merge 1 commit intoangular:masterfrom
tbosch wants to merge 1 commit intoangular:masterfrom
Conversation
tbosch
force-pushed
the
changedetection
branch
from
02a4a98 to
b6303e2
Compare
tbosch
force-pushed
the
changedetection
branch
2 times, most recently
from
1e9d4da to
af4865b
Compare
Contributor
Author
There was a problem hiding this comment.
callbacks are missing:
callAfterContentInit: directiveMetadata.callAfterContentInit,
callAfterContentChecked: directiveMetadata.callAfterContentChecked,
callAfterViewInit: directiveMetadata.callAfterViewInit,
callAfterViewChecked: directiveMetadata.callAfterViewChecked,
callOnChanges: directiveMetadata.callOnChanges,
callDoCheck: directiveMetadata.callDoCheck,
callOnInit: directiveMetadata.callOnInit,
Contributor
Author
|
Change |
Contributor
Author
|
Reviewed with @vsavkin in person. |
tbosch
added
pr_state: LGTM
action: cleanup
tbosch
force-pushed
the
changedetection
branch
from
af4865b to
6031f3d
Compare
tbosch
force-pushed
the
changedetection
branch
from
6031f3d to
9323979
Compare
tbosch
added
action: merge
|
Merging PR #3950 on behalf of @tbosch to branch presubmit-tbosch-pr-3950. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3605