feat(compiler): add full directive metadata and validation logic#3880
Closed
tbosch wants to merge 2 commits intoangular:masterfrom
Closed
feat(compiler): add full directive metadata and validation logic#3880tbosch wants to merge 2 commits intoangular:masterfrom
tbosch wants to merge 2 commits intoangular:masterfrom
Conversation
modules/angular2/src/compiler/api.ts
Outdated
Member
There was a problem hiding this comment.
Why not call this (and TemplateMeta and TypeMeta) ...Metadata for consistency ?
There was a problem hiding this comment.
Agree with @gkalpak - it would a longer, but a more explicit name.
Contributor
Author
|
Add a try/catch for expression parser and store the error in the |
Contributor
Author
|
Reviewed with @vsavkin in person |
tbosch
added
pr_state: LGTM
action: cleanup
With this, the new `TemplateParser` has feature/data parity with the `ProtoViewDto` of the `RenderCompiler`. Part of angular#3605
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.