X Tutup
Skip to content

fix(typings): emit spread parameters#3875

Closed
alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle:fix3874
Closed

fix(typings): emit spread parameters#3875
alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle:fix3874

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle commented Aug 27, 2015

Surprisingly, this is the only missing spread in the whole .d.ts:

$ diff before dist/docs/typings/angular2/angular2.d.ts
2371c2371
<      new(args: any): any;

---
>      new(...args: any): any;

@alexeagle alexeagle added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 27, 2015
@btford
Copy link
Copy Markdown
Contributor

btford commented Aug 27, 2015

Needs a test.

You could add a FooCmp constructor with two arguments here to show that the new angular2.d.ts works: https://github.com/angular/angular/blob/master/typing_spec/router_spec.ts#L13

@btford btford assigned alexeagle and unassigned btford Aug 27, 2015
@btford btford added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 27, 2015
@alexeagle alexeagle assigned btford and unassigned alexeagle Aug 27, 2015
@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Aug 27, 2015

Thanks for feeding me the right assertion. That exposed another bug :)

On Thu, Aug 27, 2015 at 1:27 PM Brian Ford notifications@github.com wrote:

Assigned #3875 #3875 to
@alexeagle https://github.com/alexeagle.

—
Reply to this email directly or view it on GitHub
#3875 (comment).

@btford
Copy link
Copy Markdown
Contributor

btford commented Aug 27, 2015

LGTM

@btford btford added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 27, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 27, 2015

User @btford forgot to say "please."

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 27, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 27, 2015

Merging PR #3875 on behalf of @btford to branch presubmit-btford-pr-3875.

@btford btford added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 27, 2015
@alexeagle alexeagle closed this in a34d4c6 Aug 27, 2015
@alexeagle alexeagle deleted the fix3874 branch August 28, 2015 16:01
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@btford btford

Labels

area: build & ci Related the build and CI infrastructure of the project cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexeagle @btford @mary-poppins @googlebot
X Tutup