X Tutup
Skip to content

feat(compile): add DomParser, TemplateParser, TemplateLoader#3839

Closed
tbosch wants to merge 1 commit intoangular:masterfrom
tbosch:compile-parser
Closed

feat(compile): add DomParser, TemplateParser, TemplateLoader#3839
tbosch wants to merge 1 commit intoangular:masterfrom
tbosch:compile-parser

Conversation

@tbosch
Copy link
Copy Markdown
Contributor

@tbosch tbosch commented Aug 25, 2015

First bits of new compile pipeline #3605

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are constructors indented by 1 space only on purpose (here and below) ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Pascal case

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Aug 26, 2015

Reviewed in person with @vsavkin

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup