X Tutup
Skip to content

fix(build): make e2e tests faster#3822

Closed
marclaval wants to merge 1 commit intoangular:masterfrom
marclaval:e2e
Closed

fix(build): make e2e tests faster#3822
marclaval wants to merge 1 commit intoangular:masterfrom
marclaval:e2e

Conversation

@marclaval
Copy link
Copy Markdown
Contributor

@marclaval marclaval commented Aug 25, 2015

While trying to put more in SauceLabs, I found out the e2e tests take 20+ minutes in our builds, mainly because protractor waits a lot.
Trying something to improve that.

@marclaval
Copy link
Copy Markdown
Contributor Author

marclaval commented Aug 25, 2015

It works!
The build time is reduced from ~32mins to ~15mins for Dart jobs and ~12mins for JS job.
The reason behind it is that each of the 92 specs ran with Protractor was waiting 14s, so that was a flat waiting time of 21+ mins.

The fix is quite hacky as it waits for the "Loading..." string to disappear from the DOM.
But I'm not familiar enough with ourbenchmarking process to validate it.
@tbosch @juliemr @yjbanov Can you please review?

@marclaval marclaval added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 25, 2015
@marclaval marclaval changed the title [WIP] fix(build): make e2e tests faster fix(build): make e2e tests faster Aug 25, 2015
@mhevery mhevery added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 25, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 25, 2015

Merging PR #3822 on behalf of @mhevery to branch presubmit-mhevery-pr-3822.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 25, 2015
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Aug 25, 2015

@Mlaval nice work sir!

@marclaval marclaval closed this in c2279dd Aug 25, 2015
@tbosch tbosch mentioned this pull request Aug 25, 2015
Closed
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Aug 25, 2015

@Mlaval We should have a properly working API to wait for Angular now. Could you work on using this instead (see #3829)?

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Aug 25, 2015

Assigned to @Mlaval as a follow up.

PatrickJS
PatrickJS reviewed Aug 26, 2015
View reviewed changes
protractor-shared.js
Copy link
Copy Markdown
Contributor

@PatrickJS PatrickJS Aug 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL you can also pass in a function rather than a string

@marclaval marclaval deleted the e2e branch December 11, 2017 10:11
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@marclaval marclaval

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marclaval @mary-poppins @mhevery @tbosch @PatrickJS @googlebot
X Tutup