X Tutup
Skip to content

fix(router): re-export of Type#3704

Closed
mhevery wants to merge 1 commit intoangular:masterfrom
mhevery:router-type
Closed

fix(router): re-export of Type#3704
mhevery wants to merge 1 commit intoangular:masterfrom
mhevery:router-type

Conversation

@mhevery
Copy link
Copy Markdown
Contributor

@mhevery mhevery commented Aug 18, 2015

Closes #3632

mhevery
mhevery reviewed Aug 18, 2015
View reviewed changes
docs/docs-package/templates/type-definition.template.html
Copy link
Copy Markdown
Contributor Author

@mhevery mhevery Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing unused file.

@mhevery mhevery mentioned this pull request Aug 18, 2015
Closed
@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 18, 2015
@btford
Copy link
Copy Markdown
Contributor

btford commented Aug 21, 2015

@mhevery Travis is red. Can you rebase and push again?

@btford btford added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 21, 2015
@btford btford assigned mhevery and unassigned btford Aug 21, 2015
@mhevery
Copy link
Copy Markdown
Contributor Author

mhevery commented Aug 22, 2015

@btford This is not a working prototype, but only steps 1 and 2 out of 3. See #3632 for details. I was hoping that someone else can solve step no 3

@mhevery mhevery added this to the alpha-37 milestone Aug 28, 2015
@mhevery mhevery added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 28, 2015
@mhevery mhevery assigned btford and unassigned mhevery Aug 28, 2015
@btford
Copy link
Copy Markdown
Contributor

btford commented Aug 28, 2015

LGTM. If CI passes, merge away.

@btford btford assigned mhevery and unassigned btford Aug 29, 2015
@btford btford added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 29, 2015
@btford
Copy link
Copy Markdown
Contributor

btford commented Aug 29, 2015

CI did not pass :(

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Aug 31, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 31, 2015

Merging PR #3704 on behalf of @mhevery to branch presubmit-mhevery-pr-3704.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 31, 2015
@mhevery mhevery closed this in b8be4bf Aug 31, 2015
@mhevery mhevery deleted the router-type branch June 2, 2017 17:08
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mhevery mhevery

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Milestone

alpha-37

Development

Successfully merging this pull request may close these issues.

Router should not export Type Interface

5 participants

@mhevery @btford @mary-poppins @tbosch @googlebot
X Tutup