fix(router): subscribe should return subscription#3695
Closed
btford wants to merge 1 commit intoangular:masterfrom
Closed
fix(router): subscribe should return subscription#3695btford wants to merge 1 commit intoangular:masterfrom
btford wants to merge 1 commit intoangular:masterfrom
Conversation
btford
added
the
action: review
Contributor
There was a problem hiding this comment.
LGTM but should you add a test ?
edit: I have just seen your initial comment: "this method itself is already called as a part of other tests". May be we should have an effective test then (ie one that would fail w/o this update).
Contributor
Author
There was a problem hiding this comment.
I chatted with @IgorMinar and we came up with a suitable effective test.
Contributor
Author
|
Sent to presubmit 🍰 |
btford
added
action: merge
|
User @btford is an outstanding citizen. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this change needs a test– this method itself is already called as a part of other tests, and the behavior of the subscription object returned doesn't need to be tested here.
Closes #3491