Closed
Conversation
marclaval
added
the
action: review
vicb
added
pr_state: LGTM
action: merge
|
Merging PR #3667 on behalf of @vicb to branch presubmit-vicb-pr-3667. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Edge browser. The only real fix is in
ListWrapper.fillbecause Edge doesn't like an explicitundefinedpassed as theendargument (it doesn't fill the array).The rest is test tuning for Edge: timers for NgZone, no support of -webkit-keyframes rules.
Edge also has the same issues as IE11 with the Internationalization API (see issue #3333), so there 5 tests still failing.