chore(packages): Updates systemjs package.#3630
chore(packages): Updates systemjs package.#3630ttowncompiled wants to merge 4 commits intoangular:masterfrom
Conversation
There was a problem hiding this comment.
Looks like Jason forgot to run npm-shrinkwrap in 84463cf
// cc @jteplitz602
There was a problem hiding this comment.
Sorry about that. In the future do I just run the shrinkwrap command whenever I modify the dependencies in package.json?
There was a problem hiding this comment.
No problems, just follow https://github.com/angular/angular/blob/master/npm-shrinkwrap.readme.md.
|
Happy to see this pr :-) |
ttowncompiled
force-pushed
the
systemjs_update
branch
from
08f96f2 to
5da8613
Compare
|
note, this should close #1975 |
ttowncompiled
force-pushed
the
systemjs_update
branch
2 times, most recently
from
f5bca86 to
24c7668
Compare
|
@ttowncompiled is there any particular reason for choosing 1.8.3 version? Asking, since there are newer releases: https://github.com/systemjs/systemjs/releases. BTW, would it be also possible to update SystemJS builder to 11+? It would solve systemjs/builder#271 for us. But I can take care of this when this PR lands. |
|
I had filed an issue a month ago with the TypeScript team. They had suggested in the issue that we would need to upgrade to 1.8.3. I don't mind checking 1.8.10 to see if it would also be a viable upgrade though. |
ttowncompiled
force-pushed
the
systemjs_update
branch
from
24c7668 to
10c283f
Compare
|
Looks like we will have to upgrade to 1.8.10. systemjs released further fixes that we will need if we are to use the TypeScript compiler to transpile to System.register format. Thanks @pkozlowski-opensource for mentioning it. |
ttowncompiled
force-pushed
the
systemjs_update
branch
2 times, most recently
from
ad7296e to
5d2f415
Compare
…temjs 0.18.10. Adds the rx path to each respective web worker loader.
ttowncompiled
force-pushed
the
systemjs_update
branch
from
5d2f415 to
fd38b1f
Compare
There was a problem hiding this comment.
why not keep the System logic in in runtime_paths.js, so this file stays just a list of imports.
|
Merging PR #3630 on behalf of @rkirov to branch presubmit-rkirov-pr-3630. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
7 participants
Updates systemjs package to version 0.18.3. Earlier version aren't compatible with the System.register format emitted by the TypeScript compiler.