X Tutup
Skip to content

feat(pipe): added the Pipe decorator and the pipe property to View#3572

Closed
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:pipes_add_pipes_decorator
Closed

feat(pipe): added the Pipe decorator and the pipe property to View#3572
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:pipes_add_pipes_decorator

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Aug 10, 2015

BREAKING CHANGE:
Instead of configuring pipes via a Pipes object, now you can configure them by providing the pipes property to the View decorator.

@Pipe({
  name: 'double'
})
class DoublePipe {
  transform(value, args) { return value * 2; }
}

@View({
  template: '{{ 10 | double}}'
  pipes: [DoublePipe]
})
class CustomComponent {}

@vsavkin vsavkin added feature Label used to distinguish feature request from other issues comp: core/pipes effort3: weeks labels Aug 10, 2015
@vsavkin vsavkin added this to the alpha-36 milestone Aug 10, 2015
@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 10, 2015
@vsavkin vsavkin force-pushed the pipes_add_pipes_decorator branch from 4c56865 to 86679a0 Compare August 10, 2015 23:07
@vsavkin vsavkin modified the milestones: alpha-35, alpha-36 Aug 10, 2015
vsavkin
vsavkin reviewed Aug 11, 2015
View reviewed changes
modules/angular2/src/core/annotations/decorators.ts
Copy link
Copy Markdown
Contributor Author

@vsavkin vsavkin Aug 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline

@jeffbcross jeffbcross added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 11, 2015
@jeffbcross jeffbcross assigned vsavkin and unassigned jeffbcross Aug 11, 2015
@jeffbcross
Copy link
Copy Markdown
Contributor

jeffbcross commented Aug 11, 2015

Looks good after comments addressed.

@vsavkin vsavkin force-pushed the pipes_add_pipes_decorator branch from 86679a0 to a810a3c Compare August 11, 2015 20:45
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Aug 11, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 11, 2015

Merging PR #3572 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3572.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 11, 2015
@vsavkin vsavkin force-pushed the pipes_add_pipes_decorator branch from a810a3c to 22b2e22 Compare August 11, 2015 22:31
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Aug 11, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 11, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 11, 2015

Merging PR #3572 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3572.

@vsavkin vsavkin force-pushed the pipes_add_pipes_decorator branch from 22b2e22 to fcc5b50 Compare August 11, 2015 23:42
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 11, 2015

Merging PR #3572 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3572.

@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Aug 11, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 11, 2015
@vsavkin
feat(pipe): added the Pipe decorator and the pipe property to View
9547a22 
BREAKING CHANGE:
    Instead of configuring pipes via a Pipes object, now you can configure them by providing the pipes property to the View decorator.

    @pipe({
      name: 'double'
    })
    class DoublePipe {
      transform(value, args) { return value * 2; }
    }

    @view({
      template: '{{ 10 | double}}'
      pipes: [DoublePipe]
    })
    class CustomComponent {}
@vsavkin vsavkin force-pushed the pipes_add_pipes_decorator branch from fcc5b50 to 9547a22 Compare August 12, 2015 00:37
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Aug 12, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 12, 2015

Merging PR #3572 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3572.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 12, 2015
@vsavkin vsavkin closed this in 5b5d31f Aug 12, 2015
goderbauer pushed a commit to goderbauer/angular that referenced this pull request Aug 15, 2015
@vsavkin @goderbauer
feat(pipe): added the Pipe decorator and the pipe property to View
4a6d8ef 
BREAKING CHANGE:
    Instead of configuring pipes via a Pipes object, now you can configure them by providing the pipes property to the View decorator.

    @pipe({
      name: 'double'
    })
    class DoublePipe {
      transform(value, args) { return value * 2; }
    }

    @view({
      template: '{{ 10 | double}}'
      pipes: [DoublePipe]
    })
    class CustomComponent {}

Closes angular#3572
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes effort3: weeks feature Label used to distinguish feature request from other issues

Projects

None yet

Milestone

alpha-35

Development

Successfully merging this pull request may close these issues.

4 participants

@vsavkin @jeffbcross @mary-poppins @googlebot
X Tutup