fix(compiler): strip <script> tag from templates#3486
fix(compiler): strip <script> tag from templates#3486pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Conversation
|
Not sure if this is the best approach to "silencing" |
|
Hi, I understand the need for the script removal but we all know that at some point someone will put a tag script in a template and report this a bug. And I can see a use for it (if you want to load jquery plugin in that component, you can either do it via import * from "libs/myjqueryplugin" or add a tag script on the template. @pkozlowski-opensource can you consider printing a warning message to the console, when in dev mode, to at least warn the developer about the removal of the script tags? (or give a compile error) |
Using
I don't think we've got good story for warning messages, so if anything, I would throw. Let's see what others got to say. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #2766