fix(collection): MapIterator.next() is not supported (Safari)#3389
Closed
marclaval wants to merge 1 commit intoangular:masterfrom
Closed
fix(collection): MapIterator.next() is not supported (Safari)#3389marclaval wants to merge 1 commit intoangular:masterfrom
marclaval wants to merge 1 commit intoangular:masterfrom
Conversation
marclaval
added
the
action: review
Contributor
There was a problem hiding this comment.
Please add a little unit test in collection_spec.ts
Contributor
Author
There was a problem hiding this comment.
There is already a unit test for that in collection_spec.ts:
describe('MapWrapper', () => {
it('should return a list of keys values', () => {
var m = new Map();
m.set('a', 'b');
expect(MapWrapper.keys(m)).toEqual(['a']);
expect(MapWrapper.values(m)).toEqual(['b']);
});
});
tbosch
added
pr_state: LGTM
action: cleanup
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3015 until we have polyfills working in Safari.