X Tutup
Skip to content

fix(core): fix type error in setElementProperty#3279

Closed
DrMarcII wants to merge 3 commits intoangular:masterfrom
DrMarcII:dom_renderer_bug
Closed

fix(core): fix type error in setElementProperty#3279
DrMarcII wants to merge 3 commits intoangular:masterfrom
DrMarcII:dom_renderer_bug

Conversation

@DrMarcII
Copy link
Copy Markdown
Contributor

Convert propertyValue to string when calling setElementAttribute.

Convert propertyValue to string when calling setElementAttribute.
@TedSander
Copy link
Copy Markdown
Contributor

@tbosch Can you take a look? or assign someone better.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test for this?

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 24, 2015
@tbosch tbosch assigned TedSander and unassigned tbosch Jul 24, 2015
@DrMarcII
Copy link
Copy Markdown
Contributor Author

@tbosch I added a test that I think will detect the problem and verify my solution. PTAL.

@TedSander
Copy link
Copy Markdown
Contributor

Looks like the travis error is valid. The clang formatter should be run?

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Jul 24, 2015

@DrMarcII Why do you only think this? Couldn't you just revert your change and run the test again to see for which error it fails?

@DrMarcII
Copy link
Copy Markdown
Contributor Author

@tbosch I actually haven't and don't actually know how to run these tests locally. I do know that this fix applied to the generated Dart code does fix the problem.

@tbosch tbosch closed this in 448264b Jul 27, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup