fix(core): fix type error in setElementProperty#3279
fix(core): fix type error in setElementProperty#3279DrMarcII wants to merge 3 commits intoangular:masterfrom DrMarcII:dom_renderer_bug
Conversation
Convert propertyValue to string when calling setElementAttribute.
|
@tbosch Can you take a look? or assign someone better. |
There was a problem hiding this comment.
Could you please add a test for this?
|
@tbosch I added a test that I think will detect the problem and verify my solution. PTAL. |
|
Looks like the travis error is valid. The clang formatter should be run? |
|
@DrMarcII Why do you only |
|
@tbosch I actually haven't and don't actually know how to run these tests locally. I do know that this fix applied to the generated Dart code does fix the problem. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Convert propertyValue to string when calling setElementAttribute.